Issue 17579005: Merge SafeStackTraceFrameIterator into SafeStackFrameIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17579005: Merge SafeStackTraceFrameIterator into SafeStackFrameIterator (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, loislo

CC:
v8-dev, alph

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Merge SafeStackTraceFrameIterator into SafeStackFrameIterator SafeStackFrameIterator was used solely to implement SafeStackTraceFrameIterator. This CL simply merges them and updates usage of SafeStackTraceFrameIterator to use SafeStackFrameIterator (a bit shorter name). BUG=None R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15305

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -41 lines)			Patch
M	src/frames.h	View	2 chunks	+3 lines, -23 lines	0 comments	Download
M	src/frames.cc	View	3 chunks	+8 lines, -15 lines	0 comments	Download
M	src/frames-inl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/profile-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/sampler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 6 months ago (2013-06-25 07:14:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15305 (presubmit successful).

Expand Messages | Collapse Messages