src/frames-inl.h - Issue 17579005: Merge SafeStackTraceFrameIterator into SafeStackFrameIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames-inl.h

Issue 17579005: Merge SafeStackTraceFrameIterator into SafeStackFrameIterator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/frames-inl.h

diff --git a/src/frames-inl.h b/src/frames-inl.h

index cf31a482c14fcbfc4faa7bdec1895a2c529b544d..c22a018fb0a1fb09bc0c5199fcf332d0c5a31c1b 100644

--- a/src/frames-inl.h

+++ b/src/frames-inl.h

@@ -324,7 +324,8 @@ inline JavaScriptFrame* JavaScriptFrameIterator::frame() const {

}

-inline JavaScriptFrame* SafeStackTraceFrameIterator::frame() const {

+inline JavaScriptFrame* SafeStackFrameIterator::frame() const {

+ ASSERT(!iteration_done_);

// TODO(1233797): The frame hierarchy needs to change. It's

// problematic that we can't use the safe-cast operator to cast to

// the JavaScript frame type, because we may encounter arguments

« no previous file with comments | « src/frames.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »