Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1757773003: [tools/perf] Raise parser error if trybot command failed to find a matching benchmark (Closed)

Created:
4 years, 9 months ago by nednguyen
Modified:
4 years, 9 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Raise parser error if trybot command failed to find a matching benchmark After this: tools/perf/run_benchmark try linux octanez usage: Run telemetry benchmarks on trybot. You can add all the benchmark options available except the --browser option [-h] <trybot name> <benchmark name> Run telemetry benchmarks on trybot. You can add all the benchmark options available except the --browser option: error: No benchmark named "octanez". Do you mean any of those benchmarks below? octane oortonline BUG=591409 Committed: https://crrev.com/00068d02c120dcfbf6cae98ff949c627a3762883 Cr-Commit-Position: refs/heads/master@{#378901}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M tools/perf/core/trybot_command.py View 2 chunks +18 lines, -1 line 0 comments Download
M tools/perf/scripts_smoke_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
nednguyen
4 years, 9 months ago (2016-03-02 23:09:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757773003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757773003/40001
4 years, 9 months ago (2016-03-02 23:15:16 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 00:38:19 UTC) #9
sullivan
lgtm Awesome! Thanks so much!
4 years, 9 months ago (2016-03-03 00:46:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757773003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757773003/40001
4 years, 9 months ago (2016-03-03 00:59:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-03 01:05:44 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:06:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00068d02c120dcfbf6cae98ff949c627a3762883
Cr-Commit-Position: refs/heads/master@{#378901}

Powered by Google App Engine
This is Rietveld 408576698