[tools/perf] Raise parser error if trybot command failed to find a matching benchmark

tools/perf/core/trybot_command.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import os
 import logging
 import re
 import subprocess
 import urllib2
 import json
 
+from core import path_util
+
+from telemetry import benchmark
+from telemetry.core import discover
 from telemetry.util import command_line
+from telemetry.util import matching
 
 
 CHROMIUM_CONFIG_FILENAME = 'tools/run-perf-test.cfg'
 BLINK_CONFIG_FILENAME = 'Tools/run-perf-test.cfg'
 SUCCESS, NO_CHANGES, ERROR = range(3)
 # Unsupported Perf bisect bots.
 EXCLUDED_BOTS = {
     'win_xp_perf_bisect',  # Goma issues: crbug.com/330900
     'win_perf_bisect_builder',
     'win64_nv_tester',
@@ skipping 132 matching lines @@
   @classmethod
   def CreateParser(cls):
     parser = argparse.ArgumentParser(
         ('Run telemetry benchmarks on trybot. You can add all the benchmark '
          'options available except the --browser option'),
         formatter_class=argparse.RawTextHelpFormatter)
     return parser
 
   @classmethod
   def ProcessCommandLineArgs(cls, parser, options, extra_args, environment):
-    del options, environment  # unused
+    del environment  # unused
     for arg in extra_args:
       if arg == '--browser' or arg.startswith('--browser='):
         parser.error('--browser=... is not allowed when running trybot.')
+    all_benchmarks = discover.DiscoverClasses(
+        start_dir=path_util.GetPerfBenchmarksDir(),
+        top_level_dir=path_util.GetPerfDir(),
+        base_class=benchmark.Benchmark).values()
+    all_benchmark_names = [b.Name() for b in all_benchmarks]
+    if options.benchmark_name not in all_benchmark_names:
+      possible_benchmark_names = matching.GetMostLikelyMatchedObject(
+          all_benchmark_names, options.benchmark_name)
+      parser.error(
+         'No benchmark named "%s". Do you mean any of those benchmarks '
+         'below?\n%s' %
+         (options.benchmark_name, '\n'.join(possible_benchmark_names)))
 
   @classmethod
   def AddCommandLineArgs(cls, parser, environment):
     del environment  # unused
     available_bots = _GetTrybotList(cls._GetBuilderList())
     parser.add_argument(
         'trybot', choices=available_bots,
         help=('specify which bots to run telemetry benchmarks on. '
               ' Allowed values are:\n' + '\n'.join(available_bots)),
         metavar='<trybot name>')
@@ skipping 215 matching lines @@
         return ERROR  # pylint: disable=lost-exception
       logging.info('Checked out original branch: %s', original_branchname)
       returncode, out, err = _RunProcess(
           ['git', 'branch', '-D', 'telemetry-tryjob'])
       if returncode:
         logging.error('Could not delete telemetry-tryjob branch. '
                       'Please delete it manually: %s', err)
         return ERROR  # pylint: disable=lost-exception
       logging.info('Deleted temp branch: telemetry-tryjob')
     return SUCCESS