Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1757703005: Fix FrontBufferedStreamTest (Closed)

Created:
4 years, 9 months ago by scroggo_chromium
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m50
Target Ref:
refs/heads/chrome/m50
Project:
skia
Visibility:
Public.

Description

Fix FrontBufferedStreamTest cherry-pick of b9e56c1ee6c4c8ae0a2e9247e504d92de4a6bfaa in master Original message below: ======================================================================== Fix FrontBufferedStreamTest TBR=scroggo@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747423002 Review URL: https://codereview.chromium.org/1747423002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/9dd860301e7c42adb41417af45f766f4eb1b2d06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M tests/FrontBufferedStreamTest.cpp View 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
lgtm FYI: This fixes the problem in https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN/builds/802/steps/dm/logs/stdio Should've seen that coming - the original ...
4 years, 9 months ago (2016-03-03 19:37:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757703005/1
4 years, 9 months ago (2016-03-03 19:37:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9dd860301e7c42adb41417af45f766f4eb1b2d06
4 years, 9 months ago (2016-03-03 19:37:32 UTC) #7
msarett
4 years, 9 months ago (2016-03-03 19:39:12 UTC) #8
Message was sent while issue was closed.
Thanks Leon!  I should have caught this...

Powered by Google App Engine
This is Rietveld 408576698