Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1747423002: Fix FrontBufferedStreamTest (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M tests/FrontBufferedStreamTest.cpp View 3 chunks +3 lines, -11 lines 1 comment Download

Messages

Total messages: 9 (5 generated)
msarett
This should fix the ASAN bot and the unpredictable crashes. https://codereview.chromium.org/1747423002/diff/1/tests/FrontBufferedStreamTest.cpp File tests/FrontBufferedStreamTest.cpp (left): https://codereview.chromium.org/1747423002/diff/1/tests/FrontBufferedStreamTest.cpp#oldcode296 ...
4 years, 9 months ago (2016-03-01 21:14:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747423002/1
4 years, 9 months ago (2016-03-01 21:14:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b9e56c1ee6c4c8ae0a2e9247e504d92de4a6bfaa
4 years, 9 months ago (2016-03-01 21:29:27 UTC) #8
scroggo
4 years, 9 months ago (2016-03-01 21:32:46 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698