Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 17577008: Revert "Remove IsInitialized checks from inlined API functions." (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Revert "Remove IsInitialized checks from inlined API functions." This reverts r15277 due to failures in layout tests. Apparently Blink still initializes the Isolate by calling v8::Null() as the first API function on some paths. TBR=svenpanne@chromium.org TEST=webkit:crypto/worker-random-values-concurrent.html Committed: http://code.google.com/p/v8/source/detail?r=15281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -21 lines) Patch
M include/v8.h View 8 chunks +11 lines, -11 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
Committed patchset #1 manually as r15281 (presubmit successful).
7 years, 6 months ago (2013-06-24 11:10:51 UTC) #1
Michael Starzinger
7 years, 6 months ago (2013-06-24 11:11:02 UTC) #2
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698