Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/isolate.cc

Issue 17577008: Revert "Remove IsInitialized checks from inlined API functions." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2198 matching lines...) Expand 10 before | Expand all | Expand 10 after
2209 2209
2210 // If we are deserializing, log non-function code objects and compiled 2210 // If we are deserializing, log non-function code objects and compiled
2211 // functions found in the snapshot. 2211 // functions found in the snapshot.
2212 if (!create_heap_objects && 2212 if (!create_heap_objects &&
2213 (FLAG_log_code || FLAG_ll_prof || logger_->is_logging_code_events())) { 2213 (FLAG_log_code || FLAG_ll_prof || logger_->is_logging_code_events())) {
2214 HandleScope scope(this); 2214 HandleScope scope(this);
2215 LOG(this, LogCodeObjects()); 2215 LOG(this, LogCodeObjects());
2216 LOG(this, LogCompiledFunctions()); 2216 LOG(this, LogCompiledFunctions());
2217 } 2217 }
2218 2218
2219 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, state_)),
2220 Internals::kIsolateStateOffset);
2219 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, embedder_data_)), 2221 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, embedder_data_)),
2220 Internals::kIsolateEmbedderDataOffset); 2222 Internals::kIsolateEmbedderDataOffset);
2221 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, heap_.roots_)), 2223 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, heap_.roots_)),
2222 Internals::kIsolateRootsOffset); 2224 Internals::kIsolateRootsOffset);
2223 2225
2224 state_ = INITIALIZED; 2226 state_ = INITIALIZED;
2225 time_millis_at_init_ = OS::TimeCurrentMillis(); 2227 time_millis_at_init_ = OS::TimeCurrentMillis();
2226 2228
2227 if (!create_heap_objects) { 2229 if (!create_heap_objects) {
2228 // Now that the heap is consistent, it's OK to generate the code for the 2230 // Now that the heap is consistent, it's OK to generate the code for the
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
2443 2445
2444 #ifdef DEBUG 2446 #ifdef DEBUG
2445 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2447 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2446 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2448 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2447 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2449 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2448 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2450 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2449 #undef ISOLATE_FIELD_OFFSET 2451 #undef ISOLATE_FIELD_OFFSET
2450 #endif 2452 #endif
2451 2453
2452 } } // namespace v8::internal 2454 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698