Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 1757403002: More user id tracking for mus: (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More user id tracking for mus: Adds UserIdTracker to track set of known/valid user ids. Start of adding test coverage for multiple windowmanagers per treehost along with a handful of fixes. BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4 Cr-Commit-Position: refs/heads/master@{#379156}

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1140 lines, -314 lines) Patch
M components/mus/mus_app.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 4 chunks +9 lines, -0 lines 0 comments Download
M components/mus/ws/access_policy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/mus/ws/connection_manager.h View 5 chunks +9 lines, -4 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 2 chunks +2 lines, -8 lines 0 comments Download
A components/mus/ws/test_utils.h View 1 2 1 chunk +243 lines, -0 lines 0 comments Download
A components/mus/ws/test_utils.cc View 1 chunk +280 lines, -0 lines 0 comments Download
A components/mus/ws/user_id.h View 1 chunk +18 lines, -0 lines 0 comments Download
A components/mus/ws/user_id_tracker.h View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A components/mus/ws/user_id_tracker.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A components/mus/ws/user_id_tracker_observer.h View 1 chunk +28 lines, -0 lines 0 comments Download
M components/mus/ws/window_manager_factory_registry.h View 1 1 chunk +31 lines, -5 lines 0 comments Download
M components/mus/ws/window_manager_factory_registry.cc View 3 chunks +66 lines, -14 lines 0 comments Download
A components/mus/ws/window_manager_factory_registry_observer.h View 1 chunk +27 lines, -0 lines 0 comments Download
M components/mus/ws/window_manager_factory_service.h View 2 chunks +20 lines, -5 lines 0 comments Download
M components/mus/ws/window_manager_factory_service.cc View 1 chunk +20 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 7 chunks +26 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 4 chunks +55 lines, -10 lines 0 comments Download
A components/mus/ws/window_tree_host_unittest.cc View 1 2 1 chunk +184 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 11 chunks +11 lines, -258 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-03 20:39:26 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-03 23:57:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757403002/40001
4 years, 9 months ago (2016-03-03 23:58:36 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-04 00:42:35 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 00:43:38 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a8a5c27a8a9189bc2ef5069e66e5c44bd1808c4
Cr-Commit-Position: refs/heads/master@{#379156}

Powered by Google App Engine
This is Rietveld 408576698