Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: components/mus/ws/window_tree_host_impl.cc

Issue 1757403002: More user id tracking for mus: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mus/ws/window_tree_host_impl.h ('k') | components/mus/ws/window_tree_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/ws/window_tree_host_impl.cc
diff --git a/components/mus/ws/window_tree_host_impl.cc b/components/mus/ws/window_tree_host_impl.cc
index 90c90d72b6a332e36cf339ffcfdc44c804e070ef..220f974176220b8a92c9e4775657a17ac5af789c 100644
--- a/components/mus/ws/window_tree_host_impl.cc
+++ b/components/mus/ws/window_tree_host_impl.cc
@@ -104,17 +104,25 @@ WindowTreeHostImpl::WindowTreeHostImpl(
frame_decoration_values_->max_title_bar_button_width = 0u;
display_manager_->Init(this);
+
+ connection_manager_->window_manager_factory_registry()->AddObserver(this);
}
WindowTreeHostImpl::~WindowTreeHostImpl() {
+ connection_manager_->window_manager_factory_registry()->RemoveObserver(this);
+
DestroyFocusController();
for (ServerWindow* window : windows_needing_frame_destruction_)
window->RemoveObserver(this);
- // TODO(sky): this may leave the WindowTreeImpls associated with the
- // WindowManagerStates still alive. The shutdown ordering is a bit iffy,
- // figure out what it should be. ConnectionManager::OnConnectionError()
- // has a check that effects this too.
+ // Destroy any trees, which triggers destroying the WindowManagerState. Copy
+ // off the WindowManagerStates as destruction mutates
+ // |window_manager_state_map_|.
+ std::set<WindowManagerState*> states;
+ for (auto& pair : window_manager_state_map_)
+ states.insert(pair.second.get());
+ for (WindowManagerState* state : states)
+ connection_manager_->DestroyTree(state->tree());
}
void WindowTreeHostImpl::Init(scoped_ptr<WindowTreeHostConnection> connection) {
@@ -180,6 +188,12 @@ WindowManagerState* WindowTreeHostImpl::GetFirstWindowManagerState() {
: window_manager_state_map_.begin()->second.get();
}
+WindowManagerState* WindowTreeHostImpl::GetWindowManagerStateForUser(
+ UserId user_id) {
+ auto iter = window_manager_state_map_.find(user_id);
+ return iter == window_manager_state_map_.end() ? nullptr : iter->second.get();
+}
+
void WindowTreeHostImpl::SetCapture(ServerWindow* window,
bool in_nonclient_area) {
ServerWindow* capture_window = event_dispatcher_.capture_window();
@@ -375,15 +389,21 @@ void WindowTreeHostImpl::CreateWindowManagerStatesFromRegistry() {
std::vector<WindowManagerFactoryService*> services =
connection_manager_->window_manager_factory_registry()->GetServices();
for (WindowManagerFactoryService* service : services) {
- scoped_ptr<WindowManagerState> wms_ptr(
- new WindowManagerState(this, service->user_id()));
- WindowManagerState* wms = wms_ptr.get();
- window_manager_state_map_[service->user_id()] = std::move(wms_ptr);
- wms->tree_ = connection_manager_->CreateTreeForWindowManager(
- this, service->window_manager_factory(), wms->root());
+ if (service->window_manager_factory())
+ CreateWindowManagerStateFromService(service);
}
}
+void WindowTreeHostImpl::CreateWindowManagerStateFromService(
+ WindowManagerFactoryService* service) {
+ scoped_ptr<WindowManagerState> wms_ptr(
+ new WindowManagerState(this, service->user_id()));
+ WindowManagerState* wms = wms_ptr.get();
+ window_manager_state_map_[service->user_id()] = std::move(wms_ptr);
+ wms->tree_ = connection_manager_->CreateTreeForWindowManager(
+ this, service->window_manager_factory(), wms->root());
+}
+
void WindowTreeHostImpl::UpdateNativeCursor(int32_t cursor_id) {
if (cursor_id != last_cursor_) {
display_manager_->SetCursorById(cursor_id);
@@ -605,5 +625,30 @@ void WindowTreeHostImpl::OnWindowDestroyed(ServerWindow* window) {
window->RemoveObserver(this);
}
+void WindowTreeHostImpl::OnActiveUserIdChanged(UserId id) {
+ // TODO(sky): this likely needs to cancel any pending events and all that.
+}
+
+void WindowTreeHostImpl::OnUserIdAdded(UserId id) {}
+
+void WindowTreeHostImpl::OnUserIdRemoved(UserId id) {
+ if (window_tree_host_connection_)
+ return;
+
+ WindowManagerState* state = GetWindowManagerStateForUser(id);
+ if (!state)
+ return;
+
+ // DestroyTree() calls back to OnWindowTreeConnectionError() and the
+ // WindowManagerState is destroyed (and removed).
+ connection_manager_->DestroyTree(state->tree());
+ DCHECK_EQ(0u, window_manager_state_map_.count(id));
+}
+
+void WindowTreeHostImpl::OnWindowManagerFactorySet(
+ WindowManagerFactoryService* service) {
+ CreateWindowManagerStateFromService(service);
+}
+
} // namespace ws
} // namespace mus
« no previous file with comments | « components/mus/ws/window_tree_host_impl.h ('k') | components/mus/ws/window_tree_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698