Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1757343002: upgrade to latest analyzer (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly
Modified:
4 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

upgrade to latest analyzer fixes https://github.com/dart-lang/dev_compiler/issues/471 Changes here are: * Analyzer now infers list/map literals * Analyzer changed how isPotentiallyMutated* APIs work, so we need to track current function * Another fix to arrow functions. We shouldn't skip generating covariant arg checks. If there were any, we use `=> { block }` form rather than `=> expr` form. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5b987b60cd5d2e7136e4dfbfa214b48446284d1b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -222 lines) Patch
M lib/runtime/dart/_debugger.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_interceptors.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M lib/runtime/dart/_internal.js View 1 2 chunks +5 lines, -2 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 6 chunks +17 lines, -17 lines 0 comments Download
M lib/runtime/dart/async.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/collection.js View 1 4 chunks +16 lines, -4 lines 0 comments Download
M lib/runtime/dart/core.js View 1 12 chunks +57 lines, -31 lines 0 comments Download
M lib/runtime/dart/html.js View 1 10 chunks +22 lines, -18 lines 0 comments Download
M lib/runtime/dart/isolate.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/js.js View 1 4 chunks +6 lines, -6 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 9 chunks +31 lines, -39 lines 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M lib/src/info.dart View 1 2 chunks +17 lines, -7 lines 0 comments Download
M lib/src/options.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.js View 1 4 chunks +22 lines, -5 lines 0 comments Download
M test/codegen/expect/es6_modules.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/js_test.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/codegen/expect/lib-typed_data-all.js View 1 12 chunks +33 lines, -35 lines 0 comments Download
M test/codegen/expect/names.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/node_modules.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/opassign.js View 1 2 chunks +6 lines, -6 lines 0 comments Download
M test/codegen/expect/syncstar_syntax.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/language/cascade2_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen/language/compile_time_constant8_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 1 6 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jennifer Messerly
4 years, 9 months ago (2016-03-03 18:36:50 UTC) #3
vsm
lgtm I'll try this out with Angular once you land.
4 years, 9 months ago (2016-03-03 19:32:20 UTC) #5
Jennifer Messerly
4 years, 9 months ago (2016-03-03 19:32:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as
5b987b60cd5d2e7136e4dfbfa214b48446284d1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698