Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: lib/src/options.dart

Issue 1757343002: upgrade to latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/info.dart ('k') | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 65938e83b892f68bf5bdce2b84d548f0e2c1c8f9..5a4fcb3deebf45632aa195ee910bedf5a7df5630 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -16,6 +16,20 @@ import 'utils.dart' show parseEnum, getEnumName;
const String _V8_BINARY_DEFAULT = 'node';
const bool _CLOSURE_DEFAULT = false;
+
+/// Older V8 versions do not accept default values with destructuring in
+/// arrow functions yet (e.g. `({a} = {}) => 1`) but happily accepts them
+/// with regular functions (e.g. `function({a} = {}) { return 1 }`).
+///
+/// Supporting the syntax:
+/// * Chrome Canary (51)
+/// * Firefox
+///
+/// Not yet supporting:
+/// * Atom (1.5.4)
+/// * Electron (0.36.3)
+///
+// TODO(ochafik): Simplify this code when our target platforms catch up.
const bool _DESTRUCTURE_NAMED_PARAMS_DEFAULT = false;
/// Options used to set up Source URI resolution in the analysis context.
« no previous file with comments | « lib/src/info.dart ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698