Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 17573017: Revert 208246 "Support using loadable module for libpeerconnecti..." (Closed)

Created:
7 years, 6 months ago by Albert Bodenhamer
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 208246 "Support using loadable module for libpeerconnecti..." Caused check_perms failure on Linux ChromiumOS. See http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/21371 > Support using loadable module for libpeerconnection on Android. > > Borrowed create_standalone_apk_action.gypi, create_standalone_apk.py and finalize_apk_action.gypi from https://codereview.chromium.org/14843017/ with some minor fix in create_standalone_apk_action.gypi. > > For some cases where libpeerconnection needs to be a loadable module, we need to add libpeerconnection.so into Chrome_apk. > This patch takes 2 steps: > 1. build chrome with libpeer_target_type=loadable_module. > 2. add libpeerconnection.so into the apk file. > > TEST=run gyp: GYP_DEFINES="$GYP_DEFINES libpeer_target_type=loadable_module" build/gyp_chromium > build chrome > re-run gyp: GYP_DEFINES="$GYP_DEFINES libpeer_target_type=loadable_module" CHROMIUM_GYP_FILE="build/android/chrome_with_libs.gyp" build/gyp_chromium > build chrome_with_libs > install Chrome-with-libs.apk and it works for https://apprtc.appspot.com > > R=cjhopman@chromium.org, mallinath@chromium.org, tommi@chromium.org > > Review URL: https://codereview.chromium.org/17569006 TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208285

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Albert Bodenhamer
7 years, 6 months ago (2013-06-24 22:57:54 UTC) #1
Albert Bodenhamer
7 years, 6 months ago (2013-06-24 22:58:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r208285.

Powered by Google App Engine
This is Rietveld 408576698