Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 17569006: Support using loadable module for libpeerconnection on Android. (Closed)

Created:
7 years, 6 months ago by wjia(left Chromium)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, punyabrata
Visibility:
Public.

Description

Support using loadable module for libpeerconnection on Android. Borrowed create_standalone_apk_action.gypi, create_standalone_apk.py and finalize_apk_action.gypi from https://codereview.chromium.org/14843017/ with some minor fix in create_standalone_apk_action.gypi. For some cases where libpeerconnection needs to be a loadable module, we need to add libpeerconnection.so into Chrome_apk. This patch takes 2 steps: 1. build chrome with libpeer_target_type=loadable_module. 2. add libpeerconnection.so into the apk file. TEST=run gyp: GYP_DEFINES="$GYP_DEFINES libpeer_target_type=loadable_module" build/gyp_chromium build chrome re-run gyp: GYP_DEFINES="$GYP_DEFINES libpeer_target_type=loadable_module" CHROMIUM_GYP_FILE="build/android/chrome_with_libs.gyp" build/gyp_chromium build chrome_with_libs install Chrome-with-libs.apk and it works for https://apprtc.appspot.com R=cjhopman@chromium.org, mallinath@chromium.org, tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208246

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -15 lines) Patch
A build/android/chrome_with_libs.gyp View 1 1 chunk +82 lines, -0 lines 0 comments Download
A build/android/create_standalone_apk.py View 1 chunk +61 lines, -0 lines 0 comments Download
A build/android/create_standalone_apk_action.gypi View 1 chunk +41 lines, -0 lines 0 comments Download
A build/android/finalize_apk_action.gypi View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/libjingle/overrides/allocator_shim/allocator_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/overrides/allocator_shim/allocator_stub.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/overrides/allocator_shim/allocator_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wjia(left Chromium)
7 years, 6 months ago (2013-06-24 00:55:01 UTC) #1
tommi (sloooow) - chröme
lgtm! excellent work Wei - I don't have enough context to review the android specific ...
7 years, 6 months ago (2013-06-24 08:09:12 UTC) #2
wjia(left Chromium)
Thanks! https://codereview.chromium.org/17569006/diff/1/build/android/chrome_with_libs.gyp File build/android/chrome_with_libs.gyp (right): https://codereview.chromium.org/17569006/diff/1/build/android/chrome_with_libs.gyp#newcode9 build/android/chrome_with_libs.gyp:9: # As an example, when building Chrome_apk with ...
7 years, 6 months ago (2013-06-24 17:56:20 UTC) #3
cjhopman
On 2013/06/24 08:09:12, tommi wrote: > lgtm! excellent work Wei - I don't have enough ...
7 years, 6 months ago (2013-06-24 18:36:34 UTC) #4
Mallinath (Gone from Chromium)
lgtm for libjingle changes
7 years, 6 months ago (2013-06-24 18:50:22 UTC) #5
wjia(left Chromium)
7 years, 6 months ago (2013-06-24 18:54:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r208246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698