Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1756973002: Reland "[api] Don't go to javascript to construct API functions" (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[api] Don't go to javascript to construct API functions" BUG= R=verwaest@chromium.org Committed: https://crrev.com/d5d4f0b80f585878130bffb40ff8e960646823d8 Cr-Commit-Position: refs/heads/master@{#34496}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -37 lines) Patch
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/execution.cc View 2 chunks +39 lines, -29 lines 1 comment Download
M src/objects.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
ptal https://codereview.chromium.org/1756973002/diff/1/src/execution.cc File src/execution.cc (right): https://codereview.chromium.org/1756973002/diff/1/src/execution.cc#newcode66 src/execution.cc:66: if (is_construct && !function->IsConstructor()) { in the original ...
4 years, 9 months ago (2016-03-02 18:15:54 UTC) #2
Toon Verwaest
lgtm
4 years, 9 months ago (2016-03-04 13:41:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756973002/1
4 years, 9 months ago (2016-03-04 13:41:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 14:03:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5d4f0b80f585878130bffb40ff8e960646823d8 Cr-Commit-Position: refs/heads/master@{#34496}
4 years, 9 months ago (2016-03-04 14:04:00 UTC) #8
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1767663002/ by machenbach@chromium.org. ...
4 years, 9 months ago (2016-03-04 15:54:42 UTC) #9
Michael Achenbach
4 years, 9 months ago (2016-03-04 15:56:01 UTC) #10
Message was sent while issue was closed.
Actually the failing test is a timeout - so not sure about "fix upstream".

Powered by Google App Engine
This is Rietveld 408576698