Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: src/objects.cc

Issue 1756973002: Reland "[api] Don't go to javascript to construct API functions" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 1100adb3fc98d2bee567ea5ed65e78ed7d96d219..eb647b0f859a6b3ebbe735a9170abf8655297f04 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1081,7 +1081,8 @@ MaybeHandle<Object> Object::GetPropertyWithAccessor(LookupIterator* it) {
Handle<Object> getter(AccessorPair::cast(*structure)->getter(), isolate);
if (getter->IsFunctionTemplateInfo()) {
auto result = Builtins::InvokeApiFunction(
- Handle<FunctionTemplateInfo>::cast(getter), receiver, 0, nullptr);
+ false, Handle<FunctionTemplateInfo>::cast(getter), receiver, 0,
+ nullptr);
if (isolate->has_pending_exception()) {
return MaybeHandle<Object>();
}
@@ -1150,9 +1151,9 @@ Maybe<bool> Object::SetPropertyWithAccessor(LookupIterator* it,
Handle<Object> setter(AccessorPair::cast(*structure)->setter(), isolate);
if (setter->IsFunctionTemplateInfo()) {
Handle<Object> argv[] = {value};
- auto result =
- Builtins::InvokeApiFunction(Handle<FunctionTemplateInfo>::cast(setter),
- receiver, arraysize(argv), argv);
+ auto result = Builtins::InvokeApiFunction(
+ false, Handle<FunctionTemplateInfo>::cast(setter), receiver,
+ arraysize(argv), argv);
if (isolate->has_pending_exception()) {
return Nothing<bool>();
}
« src/execution.cc ('K') | « src/execution.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698