Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1756963003: Add "premultiply" in ImageBitmapOptions enum PremultiplyAlpha (Closed)

Created:
4 years, 9 months ago by xidachen
Modified:
4 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "premultiply" in ImageBitmapOptions enum PremultiplyAlpha At this moment, there are two options of "none" and "default", this CL adds "premultiply". The code path for "premultiply" and "default" is the same so we can avoid large changes of any existing C++ code. Layout tests has been created to reflect this additional option. Locally I have added this option to all the conformance tests for ImageBitmap hosted by KhronosGroup/WebGL, and they all pass. Once this CL landed, there will be a pull request to update those tests. BUG=591713 Committed: https://crrev.com/ecf58aa7eb349ab2b4beaec613183810c4edf135 Cr-Commit-Position: refs/heads/master@{#379302}

Patch Set 1 #

Patch Set 2 : change parseOptions #

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756963003/1
4 years, 9 months ago (2016-03-03 15:09:22 UTC) #2
xidachen
PTAL.
4 years, 9 months ago (2016-03-03 18:01:18 UTC) #8
xidachen
On 2016/03/03 18:01:18, xidachen wrote: > PTAL. gentle ping, this CL adds the "premultiply", so ...
4 years, 9 months ago (2016-03-04 15:39:43 UTC) #10
Justin Novosad
lgtm
4 years, 9 months ago (2016-03-04 15:47:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756963003/20001
4 years, 9 months ago (2016-03-04 15:49:40 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 16:56:42 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:57:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ecf58aa7eb349ab2b4beaec613183810c4edf135
Cr-Commit-Position: refs/heads/master@{#379302}

Powered by Google App Engine
This is Rietveld 408576698