third_party/WebKit/Source/core/frame/ImageBitmap.cpp - Issue 1756963003: Add "premultiply" in ImageBitmapOptions enum PremultiplyAlpha

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 1756963003: Add "premultiply" in ImageBitmapOptions enum PremultiplyAlpha (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change parseOptions Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-with-options-expected.txt ('k') | third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

index fe8bd6ca42d3060a1558e5d30e10578c1f5c7c29..2b4e1dd436ddf49abd2594bf01f7f70136a2d310 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

@@ -429,7 +429,7 @@ void ImageBitmap::parseOptions(const ImageBitmapOptions& options, bool& flipY)

if (options.premultiplyAlpha() == imageBitmapOptionNone) {

m_isPremultiplied = false;

} else {

- ASSERT(options.premultiplyAlpha() == "default");

+ ASSERT(options.premultiplyAlpha() == "default" || options.premultiplyAlpha() == "premultiply");

}