third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h - Issue 1756953002: Stop dispatching notifyFinished for each part in a multipart response

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h

Issue 1756953002: Stop dispatching notifyFinished for each part in a multipart response (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ImageResource.cpp ('K') | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h

diff --git a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h

index 92db211febe54625ad92d1051511806ccc8faa78..c59e7a3051215c990515a5fa35373936397a5e36 100644

--- a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h

+++ b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h

@@ -55,7 +55,7 @@ public:

class CORE_EXPORT Client : public WillBeGarbageCollectedMixin {

public:

virtual ~Client() = default;

- virtual void onePartInMultipartReceived(const ResourceResponse&, bool isFirstPart) = 0;

+ virtual void onePartInMultipartReceived(const ResourceResponse&) = 0;

virtual void multipartDataReceived(const char* bytes, size_t) = 0;

DEFINE_INLINE_VIRTUAL_TRACE() {}

};

@@ -85,7 +85,6 @@ private:

bool m_isParsingTop = true;

bool m_isParsingHeaders = false;

bool m_sawLastBoundary = false;

- bool m_isFirstPart = true;

bool m_isCancelled = false;

};