third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp - Issue 1756953002: Stop dispatching notifyFinished for each part in a multipart response

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp

Issue 1756953002: Stop dispatching notifyFinished for each part in a multipart response (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ImageResource.cpp ('K') | « third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h ('k') | third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp

diff --git a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp

index 4b748fc39a32d677b6556905738784393063b99c..cfbee3c2a14dfe6af7a0ec93294530444d4a5de8 100644

--- a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp

+++ b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp

@@ -162,12 +162,8 @@ bool MultipartImageResourceParser::parseHeaders()

if (!Platform::current()->parseMultipartHeadersFromBody(m_data.data(), m_data.size(), &response, &end))

return false;

m_data.remove(0, end);

- bool isFirstPart = m_isFirstPart;

- m_isFirstPart = false;

// Send the response!

- m_client->onePartInMultipartReceived(response.toResourceResponse(), isFirstPart);

+ m_client->onePartInMultipartReceived(response.toResourceResponse());

return true;

}