Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 175693009: [Android] Remove runtime scaling constant queries (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Remove runtime scaling constant queries These constants are missing on certain devices, and won't actually be needed until crrev.com/171773012 lands. Remove them entirely to prevent further breakage on Blink dbg bots. BUG=345602 TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -82 lines) Patch
M ui/android/java/res/values/dimens.xml View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/android/java/resource_map/org/chromium/ui/R.java View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java View 4 chunks +2 lines, -26 lines 0 comments Download
M ui/gfx/android/view_configuration.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/android/view_configuration.cc View 7 chunks +7 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-22 08:49:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/175693009/1
6 years, 10 months ago (2014-02-22 08:50:09 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 19:06:11 UTC) #3
Message was sent while issue was closed.
Change committed as 252816

Powered by Google App Engine
This is Rietveld 408576698