Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java

Issue 175693009: [Android] Remove runtime scaling constant queries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/java/resource_map/org/chromium/ui/R.java ('k') | ui/gfx/android/view_configuration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java
diff --git a/ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java b/ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java
index a6ef398abb91dc8a4d9863ac8c6c05e0d1ca6369..7e1704309e58dcf7e5e5e2ae7c3fd252aecbeb6b 100644
--- a/ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java
+++ b/ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java
@@ -7,12 +7,10 @@ package org.chromium.ui.gfx;
import android.content.ComponentCallbacks;
import android.content.Context;
import android.content.res.Configuration;
-import android.content.res.Resources;
import android.view.ViewConfiguration;
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
-import org.chromium.ui.R;
/**
* This class facilitates access to ViewConfiguration-related properties, also
@@ -53,9 +51,7 @@ public class ViewConfigurationHelper {
getScaledMaximumFlingVelocity(),
getScaledMinimumFlingVelocity(),
getScaledTouchSlop(),
- getScaledDoubleTapSlop(),
- getScaledMinScalingSpan(),
- getScaledMinScalingTouchMajor());
+ getScaledDoubleTapSlop());
}
@CalledByNative
@@ -99,25 +95,6 @@ public class ViewConfigurationHelper {
}
@CalledByNative
- private int getScaledMinScalingSpan() {
- final Resources res = mAppContext.getResources();
- int id = res.getIdentifier("config_minScalingSpan", "dimen", "android");
- // Fall back to a sensible default if the internal identifier does not exist.
- if (id == 0) id = res.getDimensionPixelSize(R.dimen.config_minScalingSpan);
- return res.getDimensionPixelSize(id);
-
- }
-
- @CalledByNative
- private int getScaledMinScalingTouchMajor() {
- final Resources res = mAppContext.getResources();
- int id = res.getIdentifier("config_minScalingTouchMajor", "dimen", "android");
- // Fall back to a sensible default if the internal identifier does not exist.
- if (id == 0) id = res.getDimensionPixelSize(R.dimen.config_minScalingTouchMajor);
- return res.getDimensionPixelSize(id);
- }
-
- @CalledByNative
private static ViewConfigurationHelper createWithListener(Context context) {
ViewConfigurationHelper viewConfigurationHelper = new ViewConfigurationHelper(context);
viewConfigurationHelper.registerListener();
@@ -126,6 +103,5 @@ public class ViewConfigurationHelper {
private native void nativeUpdateSharedViewConfiguration(
int scaledMaximumFlingVelocity, int scaledMinimumFlingVelocity,
- int scaledTouchSlop, int scaledDoubleTapSlop,
- int scaledMinScalingSpan, int scaledMinScalingTouchMajor);
+ int scaledTouchSlop, int scaledDoubleTapSlop);
}
« no previous file with comments | « ui/android/java/resource_map/org/chromium/ui/R.java ('k') | ui/gfx/android/view_configuration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698