Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: chrome/browser/ui/views/ime/ime_window_browsertest.cc

Issue 1756853002: Correctly sets the security origin for the IME window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ime/ime_window_browsertest.cc
diff --git a/chrome/browser/ui/views/ime/ime_window_browsertest.cc b/chrome/browser/ui/views/ime/ime_window_browsertest.cc
index 2b8bbf77ba13276fbc2648b6933a98990ff5d9c0..e77e00eb143160c6ab2c8ce0cde22d7964dd5c70 100644
--- a/chrome/browser/ui/views/ime/ime_window_browsertest.cc
+++ b/chrome/browser/ui/views/ime/ime_window_browsertest.cc
@@ -7,6 +7,7 @@
#include "chrome/browser/ui/ime/ime_native_window.h"
#include "chrome/browser/ui/ime/ime_window.h"
#include "chrome/browser/ui/ime/ime_window_observer.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "ui/views/widget/widget.h"
@@ -40,7 +41,9 @@ class ImeWindowBrowserTest : public InProcessBrowserTest,
void CreateImeWindow(const gfx::Rect& bounds, bool follow_cursor) {
ime_window_ = new ImeWindow(
- browser()->profile(), nullptr, "about:blank",
+ browser()->profile(), nullptr,
+ browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame(),
Devlin 2016/03/02 18:05:11 Does this RFH make sense as the opener?
Shu Chen 2016/03/03 01:33:32 Done. I've made it nullptr.
+ "about:blank",
follow_cursor ? ImeWindow::FOLLOW_CURSOR : ImeWindow::NORMAL, bounds);
ime_window_->AddObserver(this);
EXPECT_FALSE(ime_window_->ime_native_window()->IsVisible());

Powered by Google App Engine
This is Rietveld 408576698