chrome/browser/ui/ime/ime_window.h - Issue 1756853002: Correctly sets the security origin for the IME window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ime/ime_window.h

Issue 1756853002: Correctly sets the security origin for the IME window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed tests. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc ('k') | chrome/browser/ui/ime/ime_window.cc » ('j') | chrome/browser/ui/views/ime/ime_window_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ime/ime_window.h

diff --git a/chrome/browser/ui/ime/ime_window.h b/chrome/browser/ui/ime/ime_window.h

index 77ffd24d2c13d544398ac220a19b78291a6e9324..b00cc5e7c038615d259ff9252e062ee6af9c207d 100644

--- a/chrome/browser/ui/ime/ime_window.h

+++ b/chrome/browser/ui/ime/ime_window.h

@@ -23,6 +23,7 @@ class GURL;

class Profile;

namespace content {

+class RenderFrameHost;

class WebContents;

}

@@ -60,6 +61,7 @@ class ImeWindow : public content::NotificationObserver,

// better to simply the client code.

ImeWindow(Profile* profile,

const extensions::Extension* extension,

+ content::RenderFrameHost* render_frame_host,

Devlin 2016/03/02 18:05:11 Document |render_frame_host| - and maybe even rena

Shu Chen 2016/03/03 01:33:32 Done.

const std::string& url,

Mode mode,

const gfx::Rect& bounds);