third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 1756483005: Option, checkbox and radio should support ':default' selector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 1756483005: Option, checkbox and radio should support ':default' selector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLButtonElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLFormControlElement.h ('k') | third_party/WebKit/Source/core/html/HTMLInputElement.h » ('j') | third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index 37736c59d0fbdb6271e964d17f5e5f795c21e778..65729e11fb8bc833fe496e243f215d84da25caa6 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -635,13 +635,6 @@ bool HTMLFormControlElement::isSuccessfulSubmitButton() const

return canBeSuccessfulSubmitButton() && !isDisabledFormControl();

}

-bool HTMLFormControlElement::isDefaultButtonForForm() const

- // HTMLFormElement::defaultButton() traverses the tree. So we check

- // canBeSuccessfulSubmitButton() first for early return.

- return canBeSuccessfulSubmitButton() && form() && form()->defaultButton() == this;

HTMLFormControlElement* HTMLFormControlElement::enclosingFormControlElement(Node* node)

{

if (!node)