third_party/WebKit/Source/core/html/HTMLButtonElement.cpp - Issue 1756483005: Option, checkbox and radio should support ':default' selector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 1756483005: Option, checkbox and radio should support ':default' selector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/pseudo-default-option.html ('K') | « third_party/WebKit/Source/core/html/HTMLButtonElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFormControlElement.h » ('j') | third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

index f9c89becb2af0466fcb39bb3821d4d51c8a8802c..fa275c012ede22880ff0db29c4e3f4954e0ec183 100644

--- a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

@@ -214,6 +214,11 @@ bool HTMLButtonElement::supportsAutofocus() const

return true;

}

+bool HTMLButtonElement::isDefaultButtonForForm() const

tkent 2016/03/04 06:39:14 Please copy the comment in HTMLFormControlElement:

ramya.v 2016/03/04 10:22:40 Done.

+ return canBeSuccessfulSubmitButton() && form() && form()->defaultButton() == this;

Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode* insertionPoint)

{

InsertionNotificationRequest request = HTMLFormControlElement::insertedInto(insertionPoint);