third_party/WebKit/Source/core/html/HTMLButtonElement.cpp - Issue 1756483005: Option, checkbox and radio should support ':default' selector

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 1756483005: Option, checkbox and radio should support ':default' selector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/css/pseudo-default-option.html ('K') | « third_party/WebKit/Source/core/html/HTMLButtonElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFormControlElement.h » ('j') | third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.

6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)	6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)

7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)	7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 196 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
207 bool HTMLButtonElement::isInteractiveContent() const	207 bool HTMLButtonElement::isInteractiveContent() const

208 {	208 {

209 return true;	209 return true;

210 }	210 }

211	211

212 bool HTMLButtonElement::supportsAutofocus() const	212 bool HTMLButtonElement::supportsAutofocus() const

213 {	213 {

214 return true;	214 return true;

215 }	215 }

216	216

	217 bool HTMLButtonElement::isDefaultButtonForForm() const

	218 {
	tkent 2016/03/04 06:39:14 Please copy the comment in HTMLFormControlElement: Please copy the comment in HTMLFormControlElement::isDefaultButtonForForm too. ramya.v 2016/03/04 10:22:40 Done. Show quoted text On 2016/03/04 06:39:14, tkent wrote: > Please copy the comment in HTMLFormControlElement::isDefaultButtonForForm too. Done.
	219 return canBeSuccessfulSubmitButton() && form() && form()->defaultButton() == this;

	220 }

	221

217 Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode * insertionPoint)	222 Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode * insertionPoint)

218 {	223 {

219 InsertionNotificationRequest request = HTMLFormControlElement::insertedInto( insertionPoint);	224 InsertionNotificationRequest request = HTMLFormControlElement::insertedInto( insertionPoint);

220 logAddElementIfIsolatedWorldAndInDocument("button", typeAttr, formmethodAttr , formactionAttr);	225 logAddElementIfIsolatedWorldAndInDocument("button", typeAttr, formmethodAttr , formactionAttr);

221 return request;	226 return request;

222 }	227 }

223	228

224 } // namespace blink	229 } // namespace blink

OLD	NEW