Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756403002: VM: Add smi fast path operations for precompiled code (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Add smi fast path operations for precompiled code The non-smi case is handled in a slow-path deferred code path. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/72a815c39ff5fde47e32bd5f12c11ca9313ee929

Patch Set 1 #

Patch Set 2 : bug fixes #

Patch Set 3 : more ops #

Patch Set 4 : cleanup #

Patch Set 5 : supports pushed arguments in slow path code #

Patch Set 6 : ported to other platforms #

Patch Set 7 : simplified register constraints on arm, arm64 #

Total comments: 17

Patch Set 8 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -48 lines) Patch
M runtime/vm/aot_optimizer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 2 3 4 3 chunks +27 lines, -11 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 4 5 6 7 4 chunks +15 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 5 6 7 3 chunks +34 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 4 5 6 7 1 chunk +85 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 4 5 6 7 1 chunk +85 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 3 4 5 6 7 1 chunk +85 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 4 5 6 7 1 chunk +103 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 9 months ago (2016-03-03 22:59:09 UTC) #3
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/1756403002/diff/120001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1756403002/diff/120001/runtime/vm/flow_graph_compiler.cc#newcode880 runtime/vm/flow_graph_compiler.cc:880: register_bit_count); this variable name and respective getter on ...
4 years, 9 months ago (2016-03-04 13:30:36 UTC) #4
Florian Schneider
https://codereview.chromium.org/1756403002/diff/120001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1756403002/diff/120001/runtime/vm/flow_graph_compiler.cc#newcode880 runtime/vm/flow_graph_compiler.cc:880: register_bit_count); On 2016/03/04 13:30:36, Vyacheslav Egorov (Google) wrote: > ...
4 years, 9 months ago (2016-03-04 16:55:10 UTC) #5
Florian Schneider
4 years, 9 months ago (2016-03-04 17:33:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as
72a815c39ff5fde47e32bd5f12c11ca9313ee929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698