Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 1756403002: VM: Add smi fast path operations for precompiled code (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc
index 35b6a5934ca74341cfeeebdbd3b94709afa73a45..a6212c2b9add40c0dd882e9bcc3e186e692af11b 100644
--- a/runtime/vm/intermediate_language_x64.cc
+++ b/runtime/vm/intermediate_language_x64.cc
@@ -2793,6 +2793,109 @@ static void EmitSmiShiftLeft(FlowGraphCompiler* compiler,
}
+class CheckedSmiSlowPath : public SlowPathCode {
+ public:
+ CheckedSmiSlowPath(CheckedSmiOpInstr* instruction, intptr_t try_index)
+ : instruction_(instruction), try_index_(try_index) { }
+
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
+ if (Assembler::EmittingComments()) {
+ __ Comment("slow path smi operation");
+ }
+ __ Bind(entry_label());
+ LocationSummary* locs = instruction_->locs();
+ Register result = locs->out(0).reg();
+ locs->live_registers()->Remove(Location::RegisterLocation(result));
+
+ compiler->SaveLiveRegisters(locs);
+ __ pushq(locs->in(0).reg());
+ __ pushq(locs->in(1).reg());
+ compiler->EmitMegamorphicInstanceCall(
+ *instruction_->call()->ic_data(),
+ instruction_->call()->ArgumentCount(),
+ instruction_->call()->deopt_id(),
+ instruction_->call()->token_pos(),
+ locs,
+ try_index_,
+ /* slow_path_argument_count = */ 2);
+ __ MoveRegister(result, RAX);
+ compiler->RestoreLiveRegisters(locs);
+ __ jmp(exit_label());
+ }
+
+ private:
+ CheckedSmiOpInstr* instruction_;
+ intptr_t try_index_;
+};
+
+
+LocationSummary* CheckedSmiOpInstr::MakeLocationSummary(Zone* zone,
+ bool opt) const {
+ const intptr_t kNumInputs = 2;
+ const intptr_t kNumTemps = 0;
+ LocationSummary* summary = new(zone) LocationSummary(
+ zone, kNumInputs, kNumTemps, LocationSummary::kCallOnSlowPath);
+ summary->set_in(0, Location::RequiresRegister());
+ summary->set_in(1, Location::RequiresRegister());
+ switch (op_kind()) {
+ case Token::kADD:
+ case Token::kSUB:
+ summary->set_out(0, Location::RequiresRegister());
+ break;
+ case Token::kBIT_OR:
+ case Token::kBIT_AND:
+ case Token::kBIT_XOR:
+ summary->set_out(0, Location::SameAsFirstInput());
+ break;
+ default:
+ UNIMPLEMENTED();
+ }
+ return summary;
+}
+
+
+void CheckedSmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ CheckedSmiSlowPath* slow_path =
+ new CheckedSmiSlowPath(this, compiler->CurrentTryIndex());
+ compiler->AddSlowPathCode(slow_path);
+ // Test operands if necessary.
+ Register left = locs()->in(0).reg();
+ Register right = locs()->in(1).reg();
+ Register result = locs()->out(0).reg();
+ __ movq(TMP, left);
+ __ orq(TMP, right);
+ __ testq(TMP, Immediate(kSmiTagMask));
+ __ j(NOT_ZERO, slow_path->entry_label());
+ switch (op_kind()) {
+ case Token::kADD:
+ __ movq(result, left);
+ __ addq(result, right);
+ __ j(OVERFLOW, slow_path->entry_label());
+ break;
+ case Token::kSUB:
+ __ movq(result, left);
+ __ subq(result, right);
+ __ j(OVERFLOW, slow_path->entry_label());
+ break;
+ case Token::kBIT_OR:
+ ASSERT(left == result);
+ __ orq(result, right);
+ break;
+ case Token::kBIT_AND:
+ ASSERT(left == result);
+ __ andq(result, right);
+ break;
+ case Token::kBIT_XOR:
+ ASSERT(left == result);
+ __ xorq(result, right);
+ break;
+ default:
+ UNIMPLEMENTED();
+ }
+ __ Bind(slow_path->exit_label());
+}
+
+
static bool CanBeImmediate(const Object& constant) {
return constant.IsSmi() &&
Immediate(reinterpret_cast<int64_t>(constant.raw())).is_int32();
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698