runtime/observatory/lib/src/elements/debugger.dart - Issue 1756393002: Fix some service protocol isolate lifecycle races

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/debugger.dart

diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart

index 6595447668fe6edf0c83f9110a3fa778b57b4aae..81541ef595d7032a7b5e2d3f36859e6fee758bc9 100644

--- a/runtime/observatory/lib/src/elements/debugger.dart

+++ b/runtime/observatory/lib/src/elements/debugger.dart

@@ -1524,7 +1524,9 @@ class ObservatoryDebugger extends Debugger {

}

void _reportPause(ServiceEvent event) {

- if (event.kind == ServiceEvent.kPauseStart) {

+ if (event.kind == ServiceEvent.kNone) {

+ console.print("Paused until embedder makes the isolate runnable.");

+ } else if (event.kind == ServiceEvent.kPauseStart) {

console.print(

"Paused at isolate start "

"(type 'continue' [F7] or 'step' [F10] to start the isolate')");