Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library debugger_page_element; 5 library debugger_page_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'dart:math'; 9 import 'dart:math';
10 import 'observatory_element.dart'; 10 import 'observatory_element.dart';
(...skipping 1506 matching lines...) Expand 10 before | Expand all | Expand 10 after
1517 'paused.'); 1517 'paused.');
1518 } else { 1518 } else {
1519 console.printBold("Type 'set break-on-exception Unhandled' to pause the" 1519 console.printBold("Type 'set break-on-exception Unhandled' to pause the"
1520 " isolate when an unhandled exception occurs."); 1520 " isolate when an unhandled exception occurs.");
1521 console.printBold("You can make this the default by running with " 1521 console.printBold("You can make this the default by running with "
1522 "--pause-isolates-on-unhandled-exceptions"); 1522 "--pause-isolates-on-unhandled-exceptions");
1523 } 1523 }
1524 } 1524 }
1525 1525
1526 void _reportPause(ServiceEvent event) { 1526 void _reportPause(ServiceEvent event) {
1527 if (event.kind == ServiceEvent.kPauseStart) { 1527 if (event.kind == ServiceEvent.kNone) {
1528 console.print("Paused until embedder makes the isolate runnable.");
1529 } else if (event.kind == ServiceEvent.kPauseStart) {
1528 console.print( 1530 console.print(
1529 "Paused at isolate start " 1531 "Paused at isolate start "
1530 "(type 'continue' [F7] or 'step' [F10] to start the isolate')"); 1532 "(type 'continue' [F7] or 'step' [F10] to start the isolate')");
1531 } else if (event.kind == ServiceEvent.kPauseExit) { 1533 } else if (event.kind == ServiceEvent.kPauseExit) {
1532 console.print( 1534 console.print(
1533 "Paused at isolate exit " 1535 "Paused at isolate exit "
1534 "(type 'continue' or [F7] to exit the isolate')"); 1536 "(type 'continue' or [F7] to exit the isolate')");
1535 _reportIsolateError(isolate, event.kind); 1537 _reportIsolateError(isolate, event.kind);
1536 } else if (event.kind == ServiceEvent.kPauseException) { 1538 } else if (event.kind == ServiceEvent.kPauseException) {
1537 console.print( 1539 console.print(
(...skipping 1132 matching lines...) Expand 10 before | Expand all | Expand 10 after
2670 } 2672 }
2671 }); 2673 });
2672 } 2674 }
2673 2675
2674 void focus() { 2676 void focus() {
2675 $['textBox'].focus(); 2677 $['textBox'].focus();
2676 } 2678 }
2677 2679
2678 DebuggerInputElement.created() : super.created(); 2680 DebuggerInputElement.created() : super.created();
2679 } 2681 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/app/application.dart ('k') | runtime/observatory/lib/src/elements/isolate_summary.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698