runtime/observatory/lib/src/app/application.dart - Issue 1756393002: Fix some service protocol isolate lifecycle races

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/app/application.dart

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/app/application.dart

diff --git a/runtime/observatory/lib/src/app/application.dart b/runtime/observatory/lib/src/app/application.dart

index 644b65912cb20d2426e75cf0062dfdc76fdc44b0..6f58f24c28a038a908395ebc7de49c025d1fd8b6 100644

--- a/runtime/observatory/lib/src/app/application.dart

+++ b/runtime/observatory/lib/src/app/application.dart

@@ -109,6 +109,7 @@ class ObservatoryApplication extends Observable {

case ServiceEvent.kPauseBreakpoint:

case ServiceEvent.kPauseInterrupted:

case ServiceEvent.kPauseException:

+ case ServiceEvent.kPauseUntilRunnable:

turnidge 2016/03/03 17:15:01 We will never receive this event. Maybe make it i

Cutch 2016/03/03 19:22:00 Done.

removePauseEvents(event.isolate);

notifications.add(new Notification.fromEvent(event));

break;