Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: runtime/observatory/lib/src/app/application.dart

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of app; 5 part of app;
6 6
7 class Notification { 7 class Notification {
8 Notification.fromEvent(this.event); 8 Notification.fromEvent(this.event);
9 Notification.fromException(this.exception, this.stacktrace); 9 Notification.fromException(this.exception, this.stacktrace);
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 case ServiceEvent.kIsolateExit: 102 case ServiceEvent.kIsolateExit:
103 case ServiceEvent.kResume: 103 case ServiceEvent.kResume:
104 removePauseEvents(event.isolate); 104 removePauseEvents(event.isolate);
105 break; 105 break;
106 106
107 case ServiceEvent.kPauseStart: 107 case ServiceEvent.kPauseStart:
108 case ServiceEvent.kPauseExit: 108 case ServiceEvent.kPauseExit:
109 case ServiceEvent.kPauseBreakpoint: 109 case ServiceEvent.kPauseBreakpoint:
110 case ServiceEvent.kPauseInterrupted: 110 case ServiceEvent.kPauseInterrupted:
111 case ServiceEvent.kPauseException: 111 case ServiceEvent.kPauseException:
112 case ServiceEvent.kPauseUntilRunnable:
turnidge 2016/03/03 17:15:01 We will never receive this event. Maybe make it i
Cutch 2016/03/03 19:22:00 Done.
112 removePauseEvents(event.isolate); 113 removePauseEvents(event.isolate);
113 notifications.add(new Notification.fromEvent(event)); 114 notifications.add(new Notification.fromEvent(event));
114 break; 115 break;
115 116
116 case ServiceEvent.kInspect: 117 case ServiceEvent.kInspect:
117 notifications.add(new Notification.fromEvent(event)); 118 notifications.add(new Notification.fromEvent(event));
118 break; 119 break;
119 120
120 default: 121 default:
121 // Ignore unrecognized events. 122 // Ignore unrecognized events.
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 } 235 }
235 236
236 // TODO(turnidge): Report this failure via analytics. 237 // TODO(turnidge): Report this failure via analytics.
237 Logger.root.warning('Caught exception: ${e}\n${st}'); 238 Logger.root.warning('Caught exception: ${e}\n${st}');
238 notifications.add(new Notification.fromException(e, st)); 239 notifications.add(new Notification.fromException(e, st));
239 } 240 }
240 241
241 // This map keeps track of which curly-blocks have been expanded by the user. 242 // This map keeps track of which curly-blocks have been expanded by the user.
242 Map<String,bool> expansions = {}; 243 Map<String,bool> expansions = {};
243 } 244 }
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/debugger.dart » ('j') | runtime/observatory/lib/src/elements/debugger.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698