Issue 1756363003: Merge "ImageInputType::ensurePrimaryContent should recreate UA shadow tree." to M49 branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1756363003: Merge "ImageInputType::ensurePrimaryContent should recreate UA shadow tree." to M49 branch (Closed)

Created:
4 years, 9 months ago by tkent

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

Merge "ImageInputType::ensurePrimaryContent should recreate UA shadow tree." to M49 branch Once the fallback shadow tree was created, it was never recreated even if ensurePrimaryContent was called. Such situation happens by updating |src| attribute. BUG=589838 Review URL: https://codereview.chromium.org/1732753004 Cr-Commit-Position: refs/heads/master@{#377804} (cherry picked from commit 2386a6a49ea992a1e859eb0296c1cc53e5772cdb) Committed: https://chromium.googlesource.com/chromium/src/+/f75158f5e6aefe1cfd901e382757c243dacdba2c

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp	View		1 chunk	+13 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/html/forms/ImageInputType.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

tkent

4 years, 9 months ago (2016-03-03 06:37:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f75158f5e6aefe1cfd901e382757c243dacdba2c.