Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1732753004: ImageInputType::ensurePrimaryContent should recreate UA shadow tree. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageInputType::ensurePrimaryContent should recreate UA shadow tree. Once the fallback shadow tree was created, it was never recreated even if ensurePrimaryContent was called. Such situation happens by updating |src| attribute. BUG=589838 Committed: https://crrev.com/2386a6a49ea992a1e859eb0296c1cc53e5772cdb Cr-Commit-Position: refs/heads/master@{#377804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ImageInputType.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
Keishi, would you review this please?
4 years, 7 months ago (2016-02-26 01:24:44 UTC) #3
keishi
LGTM
4 years, 7 months ago (2016-02-26 02:01:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732753004/1
4 years, 7 months ago (2016-02-26 03:37:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-02-26 04:04:34 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-02-26 04:05:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2386a6a49ea992a1e859eb0296c1cc53e5772cdb
Cr-Commit-Position: refs/heads/master@{#377804}

Powered by Google App Engine
This is Rietveld 408576698