|
|
Revert of Extract webkit_unit_tests from blink_web component. (patchset #16 id:300001 of https://codereview.chromium.org/1676083002/ )
Reason for revert:
Broke compile: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan%20%28dbg%29
Original issue's description:
> Extract webkit_unit_tests from blink_web component.
>
> - Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
> of the others, rather than defined in a header.
> - Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
> to export symbols from blink_web to webkit_unit_tests.
> - Export symbols used from unit tests that aren't yet exported.
> - Remove build logic to compile unit tests into blink_web component in component
> (shared_library) builds.
> - Handle MSVC C4275 issues: base classes are either exported or, if they are
> clearly pure-interface or pure-data, marked to suppress the warning.
> - Adds an explicit web -> base dependency (due to platform using base, and gyp
> not propagating this). This is similar to the equivalent in core.
> - Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
> and only happened to work before because one of the modules unit tests included
> the header, and that was previously linked into blink_web.
>
> This makes the blink_web component substantially smaller, as it no
> longer pulls in unit tests, gtest, and so on. It also unblocks
> removal of several hacks that existed to accommodate the previous
> setup.
>
> BUG= 590749
>
> Committed: https://crrev.com/737c4d032a36133f1045a3e399c922a948b29f85
> Cr-Commit-Position: refs/heads/master@{#378773}
TBR=haraken@chromium.org,pdr@chromium.org,jbroman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 590749
Committed: https://crrev.com/4a75239f5b05e0b031dcb94eac91cc58a6c9e584
Cr-Commit-Position: refs/heads/master@{#378853}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+156 lines, -171 lines) |
Patch |
 |
M |
third_party/WebKit/Source/core/plugins/PluginView.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/modules.gyp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/BUILD.gn
|
View
|
|
4 chunks |
+50 lines, -25 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/ChromeClientImpl.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/ExternalPopupMenu.h
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/FindInPageCoordinates.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/LinkHighlightImpl.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/PageOverlay.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/PageWidgetDelegate.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/TextFinder.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/web/WebExport.h
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebFrameImplBase.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebInputEventConversion.h
|
View
|
|
6 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebLocalFrameImpl.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebPluginContainerImpl.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebRemoteFrameImpl.h
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebSettingsImpl.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebViewImpl.h
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/web.gyp
|
View
|
|
5 chunks |
+43 lines, -25 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/web.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/web_tests.gyp
|
View
|
|
2 chunks |
+10 lines, -13 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/wtf/Compiler.h
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/platform/WebCommon.h
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/platform/WebRTCDataChannelHandlerClient.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebDocument.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebElement.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebHistoryItem.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebNode.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebTestingSupport.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 6 (1 generated)
|