Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 1756343002: Revert of Extract webkit_unit_tests from blink_web component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebFrameImplBase_h 5 #ifndef WebFrameImplBase_h
6 #define WebFrameImplBase_h 6 #define WebFrameImplBase_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "web/WebExport.h"
10 #include "wtf/text/AtomicString.h" 9 #include "wtf/text/AtomicString.h"
11 10
12 namespace blink { 11 namespace blink {
13 12
14 class Frame; 13 class Frame;
15 class FrameHost; 14 class FrameHost;
16 class FrameOwner; 15 class FrameOwner;
17 16
18 // WebFrameImplBase exists to avoid the diamond inheritance problem: 17 // WebFrameImplBase exists to avoid the diamond inheritance problem:
19 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame. 18 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame.
20 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl 19 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl
21 // implements WebRemoteFrame. 20 // implements WebRemoteFrame.
22 // - The private implementations should share some functionality, but cannot 21 // - The private implementations should share some functionality, but cannot
23 // inherit from a common base class inheriting WebFrame. This would result in 22 // inherit from a common base class inheriting WebFrame. This would result in
24 // WebFrame beind inherited from two different base classes. 23 // WebFrame beind inherited from two different base classes.
25 // 24 //
26 // To get around this, only the private implementations have WebFrameImplBase as 25 // To get around this, only the private implementations have WebFrameImplBase as
27 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying 26 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying
28 // implementation as an instance of the base class, but has no inheritance 27 // implementation as an instance of the base class, but has no inheritance
29 // relationship with it. The cost is a virtual indirection, but this is nicer 28 // relationship with it. The cost is a virtual indirection, but this is nicer
30 // than the previous manual dispatch emulating real virtual dispatch. 29 // than the previous manual dispatch emulating real virtual dispatch.
31 class WEB_EXPORT WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinal ized<WebFrameImplBase> { 30 class WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinalized<WebFra meImplBase> {
32 public: 31 public:
33 virtual ~WebFrameImplBase(); 32 virtual ~WebFrameImplBase();
34 33
35 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString & name, const AtomicString& uniqueName) = 0; 34 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString & name, const AtomicString& uniqueName) = 0;
36 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const... 35 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const...
37 virtual Frame* frame() const = 0; 36 virtual Frame* frame() const = 0;
38 37
39 DECLARE_VIRTUAL_TRACE(); 38 DECLARE_VIRTUAL_TRACE();
40 }; 39 };
41 40
42 } // namespace blink 41 } // namespace blink
43 42
44 #endif // WebFrameImplBase_h 43 #endif // WebFrameImplBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebExport.h ('k') | third_party/WebKit/Source/web/WebInputEventConversion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698