Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5 id:80001 of https://c…

Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5 id:80001 of https://codereview.chromium.org/1734203002/ )"

This reverts commit f331574002bdde48e2c8ee0a657f202252548f8e aka https://codereview.chromium.org/1746353002

The crashes that it caused are now fixed by http://crrev.com/1755543002

Original description:
> Fully (?) fix overflow: auto with delayed scroll updates
>
> The scroll delaying code, used by Flexbox, never lays out the
> parent after the child relayout. This is a problem especially
> because the layout can add/remove a horizontal scrollbar,
> which changes the height of the element. A vertical scrollbar
> has this problem less often, though it sometimes does, especially
> in case of flex items. As far as I can tell, this never worked
> correctly since the scroll delaying code existed.
>
> This patch changes it so that when we eventually do the scroll info
> updates, we mark the ancestor chain for layout (up to the outer flexbox)
> and then call layoutFlexItems again, to do the correct layout.
>
> See also the discussion thread at
> https://groups.google.com/a/chromium.org/d/topic/layout-dev/e7Wzvxu7qiA/discussion
>
> BUG=579401, 584363
>
> Review URL: https://codereview.chromium.org/1734203002

BUG=579401, 584363, 525316
R=leviw@chromium.org

Committed: https://crrev.com/0bd7c3283a172513fbd1a7d8cad7ad244b11b60f
Cr-Commit-Position: refs/heads/master@{#378896}

[cbiesinger, 2016-03-02 21:09:38]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 21:10:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756003003/1

[leviw_travelin_and_unemployed, 2016-03-02 21:36:35]

Any chance you made a minimized crash test case we could add to this?

[cbiesinger, 2016-03-02 21:42:41]

On 2016/03/02 21:36:35, leviw wrote:
> Any chance you made a minimized crash test case we could add to this?

I haven't made one yet. Do you want me to make one?

[leviw_travelin_and_unemployed, 2016-03-02 21:44:54]

It'd certainly be nice to have. LGTM anyhow.

[commit-bot: I haz the power, 2016-03-03 00:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 00:28:30]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2016-03-03 00:36:26]

It is very hard to write a testcase, I've been trying for a few hours now. I
feel like kojii's testcase in his patch should be good enough for now. Will land
this.

[cbiesinger, 2016-03-03 00:36:37]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-03-03 00:37:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756003003/1

[commit-bot: I haz the power, 2016-03-03 00:43:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-03 00:44:21]

Description was changed from

==========
Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5
id:80001 of https://codereview.chromium.org/1734203002/ )"

This reverts commit f331574002bdde48e2c8ee0a657f202252548f8e aka
https://codereview.chromium.org/1746353002

The crashes that it caused are now fixed by http://crrev.com/1755543002

Original description:
> Fully (?) fix overflow: auto with delayed scroll updates
>
> The scroll delaying code, used by Flexbox, never lays out the
> parent after the child relayout. This is a problem especially
> because the layout can add/remove a horizontal scrollbar,
> which changes the height of the element. A vertical scrollbar
> has this problem less often, though it sometimes does, especially
> in case of flex items. As far as I can tell, this never worked
> correctly since the scroll delaying code existed.
>
> This patch changes it so that when we eventually do the scroll info
> updates, we mark the ancestor chain for layout (up to the outer flexbox)
> and then call layoutFlexItems again, to do the correct layout.
>
> See also the discussion thread at
>
https://groups.google.com/a/chromium.org/d/topic/layout-dev/e7Wzvxu7qiA/discu...
>
> BUG=579401,584363
>
> Review URL: https://codereview.chromium.org/1734203002

BUG=579401,584363,525316
R=leviw@chromium.org
==========

to

==========
Reland "Fully (?) fix overflow: auto with delayed scroll updates (patchset #5
id:80001 of https://codereview.chromium.org/1734203002/ )"

This reverts commit f331574002bdde48e2c8ee0a657f202252548f8e aka
https://codereview.chromium.org/1746353002

The crashes that it caused are now fixed by http://crrev.com/1755543002

Original description:
> Fully (?) fix overflow: auto with delayed scroll updates
>
> The scroll delaying code, used by Flexbox, never lays out the
> parent after the child relayout. This is a problem especially
> because the layout can add/remove a horizontal scrollbar,
> which changes the height of the element. A vertical scrollbar
> has this problem less often, though it sometimes does, especially
> in case of flex items. As far as I can tell, this never worked
> correctly since the scroll delaying code existed.
>
> This patch changes it so that when we eventually do the scroll info
> updates, we mark the ancestor chain for layout (up to the outer flexbox)
> and then call layoutFlexItems again, to do the correct layout.
>
> See also the discussion thread at
>
https://groups.google.com/a/chromium.org/d/topic/layout-dev/e7Wzvxu7qiA/discu...
>
> BUG=579401,584363
>
> Review URL: https://codereview.chromium.org/1734203002

BUG=579401,584363,525316
R=leviw@chromium.org

Committed: https://crrev.com/0bd7c3283a172513fbd1a7d8cad7ad244b11b60f
Cr-Commit-Position: refs/heads/master@{#378896}
==========

[commit-bot: I haz the power, 2016-03-03 00:44:23]

Patchset 1 (id:??) landed as
https://crrev.com/0bd7c3283a172513fbd1a7d8cad7ad244b11b60f
Cr-Commit-Position: refs/heads/master@{#378896}

[lushnikov, 2016-03-09 02:31:57]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1775293002/ by lushnikov@chromium.org.

The reason for reverting is: Please see crbug.com/593209 for details. .