Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1755953002: Update "fullscreen" to "full screen" in all strings. (Closed)

Created:
4 years, 9 months ago by Matt Giuca
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update "fullscreen" to "full screen" in all strings. Notably, the fullscreen bubble now says "Press Esc to exit full screen". BUG=591260 Committed: https://crrev.com/5aa4bd9331e2bc1c20cfbf9bfee703c16107bf0d Cr-Commit-Position: refs/heads/master@{#381138}

Patch Set 1 #

Patch Set 2 : Also change to two words on Android. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Matt Giuca
4 years, 9 months ago (2016-03-02 02:12:23 UTC) #2
Matt Giuca
+dtrainor: "Full screen" string changes for Android.
4 years, 9 months ago (2016-03-03 04:36:53 UTC) #4
David Trainor- moved to gerrit
lgtm
4 years, 9 months ago (2016-03-04 05:14:28 UTC) #5
Matt Giuca
Alex: Ping on the string change?
4 years, 9 months ago (2016-03-10 02:44:47 UTC) #6
ainslie
Errm. What do you need from me?
4 years, 9 months ago (2016-03-10 02:47:17 UTC) #7
Matt Giuca
l g t m. (Technically not required because I got another reviewer, but David was ...
4 years, 9 months ago (2016-03-10 07:20:36 UTC) #8
ainslie
Ok. LGTM.
4 years, 9 months ago (2016-03-10 13:50:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755953002/40001
4 years, 9 months ago (2016-03-10 23:30:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129118) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-11 00:03:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755953002/40001
4 years, 9 months ago (2016-03-14 23:41:29 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-15 00:42:36 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 00:44:14 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5aa4bd9331e2bc1c20cfbf9bfee703c16107bf0d
Cr-Commit-Position: refs/heads/master@{#381138}

Powered by Google App Engine
This is Rietveld 408576698