Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1755853002: Remove old paint offset caching code (Closed)

Created:
4 years, 9 months ago by Xianzhu
Modified:
4 years, 9 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old paint offset caching code This is preparation to implement new paint invalidation for SPv1 (slimmingPaintInvalidation). BUG=591199 Committed: https://crrev.com/9200103f3f0c21d9bd88c669159a43097ba185ed Cr-Commit-Position: refs/heads/master@{#378674}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -169 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 2 2 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FileUploadControlPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FrameSetPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/HTMLCanvasPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.cpp View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h View 1 2 2 chunks +12 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp View 6 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.cpp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 5 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Xianzhu
4 years, 9 months ago (2016-03-01 23:18:45 UTC) #2
chrishtr
lgtm
4 years, 9 months ago (2016-03-01 23:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755853002/20001
4 years, 9 months ago (2016-03-01 23:29:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/166703) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 23:35:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755853002/40001
4 years, 9 months ago (2016-03-02 00:28:48 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 03:38:38 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 03:40:17 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9200103f3f0c21d9bd88c669159a43097ba185ed
Cr-Commit-Position: refs/heads/master@{#378674}

Powered by Google App Engine
This is Rietveld 408576698