third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp - Issue 1755853002: Remove old paint offset caching code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 1755853002: Remove old paint offset caching code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

index b3aa41171c82caf2ec933565d74ffa4283ea9616..1da9267e7be97bd7afd786418a6532b6b31c54b3 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

@@ -166,7 +166,7 @@ bool PaintController::clientCacheIsValid(const DisplayItemClient& client) const

void PaintController::invalidatePaintOffset(const DisplayItemClient& client)

{

- ASSERT(RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled());

+ ASSERT(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());

invalidate(client);

#if ENABLE(ASSERT)

@@ -178,7 +178,7 @@ void PaintController::invalidatePaintOffset(const DisplayItemClient& client)

#if ENABLE(ASSERT)

bool PaintController::paintOffsetWasInvalidated(const DisplayItemClient& client) const

{

- ASSERT(RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled());

+ ASSERT(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());

return m_clientsWithPaintOffsetInvalidations.contains(&client);

}

#endif

@@ -348,7 +348,7 @@ void PaintController::commitNewDisplayItemsInternal(const LayoutSize& offsetFrom

if (newDisplayItemHasCachedType) {

ASSERT(newDisplayItem.isCached());

- ASSERT(clientCacheIsValid(newDisplayItem.client()) || (RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled() && !paintOffsetWasInvalidated(newDisplayItem.client())));

+ ASSERT(clientCacheIsValid(newDisplayItem.client()) || (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && !paintOffsetWasInvalidated(newDisplayItem.client())));

if (!isSynchronized) {

currentIt = findOutOfOrderCachedItem(newDisplayItemId, outOfOrderIndexContext);

@@ -382,7 +382,7 @@ void PaintController::commitNewDisplayItemsInternal(const LayoutSize& offsetFrom

ASSERT(!newDisplayItem.isDrawing()

|| newDisplayItem.skippedCache()

|| !clientCacheIsValid(newDisplayItem.client())

- || (RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled() && paintOffsetWasInvalidated(newDisplayItem.client())));

+ || (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && paintOffsetWasInvalidated(newDisplayItem.client())));

updatedList.appendByMoving(*newIt, visualRectForDisplayItem(*newIt, offsetFromLayoutObject));