Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1755843003: Build System: Remove some warning suppression. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 45c8e34c084a48396934b2482808c58f90af18fd..da32a2634e5fbde6aad9e1a1a053be34c0b810d1 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -746,7 +746,6 @@ default_warning_flags += [
# Disables.
"-Wno-missing-field-initializers", # "struct foo f = {0};"
- "-Wno-unused-parameter", # Unused function parameters.
]
if (is_mac) {
@@ -825,17 +824,6 @@ if (is_clang) {
# code generated by flex (used in angle) contains that keyword.
# http://crbug.com/255186
"-Wno-deprecated-register",
-
- # TODO(thakis): This used to be implied by -Wno-unused-function,
- # which we no longer use. Check if it makes sense to remove
- # this as well. http://crbug.com/316352
- "-Wno-unneeded-internal-declaration",
-
- # TODO(thakis): Remove, http://crbug.com/263960
- "-Wno-reserved-user-defined-literal",
-
- # TODO(hans): Get this cleaned up.
- "-Wno-inconsistent-missing-override",
]
# NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
@@ -846,9 +834,6 @@ if (is_clang) {
default_warning_flags += [
# TODO(smklein): Enable this, crbug.com/507717
"-Wno-shift-negative-value",
-
- # TODO(smklein): Consider enabling this once not broken by third party
- "-Wno-bitfield-width",
]
}
}
@@ -919,6 +904,14 @@ config("no_chromium_code") {
"-Wno-deprecated",
]
}
+
+ if (is_clang) {
+ cflags += [
+ # TODO(hans): Get this cleaned up.
+ "-Wno-inconsistent-missing-override",
+ ]
+ }
+
cflags += default_warning_flags
cflags_cc += default_warning_flags_cc
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698