Build System: Remove some warning suppression.

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 if (current_cpu == "arm") {
   import("//build/config/arm.gni")
 }
 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
@@ skipping 728 matching lines @@
 default_warning_flags_cc = []
 
 # Common GCC warning setup.
 default_warning_flags += [
   # Enables.
   "-Wendif-labels",  # Weird old-style text after an #endif.
   "-Werror",  # Warnings as errors.
 
   # Disables.
   "-Wno-missing-field-initializers",  # "struct foo f = {0};"
-  "-Wno-unused-parameter",  # Unused function parameters.
 ]
 
 if (is_mac) {
   default_warning_flags += [ "-Wnewline-eof" ]
   if (!is_nacl) {
     # When compiling Objective-C, warns if a method is used whose
     # availability is newer than the deployment target. This is not
     # required when compiling Chrome for iOS.
     default_warning_flags += [ "-Wpartial-availability" ]
   }
@@ skipping 58 matching lines @@
     "-Wno-char-subscripts",
 
     # Warns on switches on enums that cover all enum values but
     # also contain a default: branch. Chrome is full of that.
     "-Wno-covered-switch-default",
 
     # Clang considers the `register` keyword as deprecated, but e.g.
     # code generated by flex (used in angle) contains that keyword.
     # http://crbug.com/255186
     "-Wno-deprecated-register",
-
-    # TODO(thakis): This used to be implied by -Wno-unused-function,
-    # which we no longer use. Check if it makes sense to remove
-    # this as well. http://crbug.com/316352
-    "-Wno-unneeded-internal-declaration",
-
-    # TODO(thakis): Remove, http://crbug.com/263960
-    "-Wno-reserved-user-defined-literal",
-
-    # TODO(hans): Get this cleaned up.
-    "-Wno-inconsistent-missing-override",
   ]
 
   # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
   # always have different versions. Certain flags may not be recognized by
   # one version or the other.
   if (!is_nacl) {
     # Flags NaCl (Clang 3.7) does not recognize.
     default_warning_flags += [
       # TODO(smklein): Enable this, crbug.com/507717
       "-Wno-shift-negative-value",
-
-      # TODO(smklein): Consider enabling this once not broken by third party
-      "-Wno-bitfield-width",
     ]
   }
 }
 
 # chromium_code ---------------------------------------------------------------
 #
 # Toggles between higher and lower warnings for code that is (or isn't)
 # part of Chromium.
 
 config("chromium_code") {
@@ skipping 50 matching lines @@
     cflags += [
       # Don't warn about printf format problems. This is off by default in gcc
       # but on in Ubuntu's gcc(!).
       "-Wno-format",
     ]
     cflags_cc += [
       # Don't warn about hash_map in third-party code.
       "-Wno-deprecated",
     ]
   }
+
+  if (is_clang) {
+    cflags += [
+      # TODO(hans): Get this cleaned up.
+      "-Wno-inconsistent-missing-override",
+    ]
+  }
+
   cflags += default_warning_flags
   cflags_cc += default_warning_flags_cc
 }
 
 # rtti ------------------------------------------------------------------------
 #
 # Allows turning Run-Time Type Identification on or off.
 
 config("rtti") {
 }
@@ skipping 185 matching lines @@
   if (symbol_level == 0) {
     configs = [ ":no_symbols" ]
   } else if (symbol_level == 1) {
     configs = [ ":minimal_symbols" ]
   } else if (symbol_level == 2) {
     configs = [ ":symbols" ]
   } else {
     assert(false)
   }
 }