Issue 1755843003: Build System: Remove some warning suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1755843003: Build System: Remove some warning suppression. (Closed)

Created:
4 years, 9 months ago by Sean Klein

Modified:
4 years, 9 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Build System: Remove some warning suppression. For warnings which aren't removed, restrict them to third_party with the "no_chromium_code" config. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/042ad69c2975628a6f17bf72a5055d280c96aeb7

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -15 lines)			Patch
	M	build/config/compiler/BUILD.gn	View	1	4 chunks	+8 lines, -15 lines	0 comments	Download

Total messages: 6 (3 generated)

Sean Klein

4 years, 9 months ago (2016-03-02 21:45:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
042ad69c2975628a6f17bf72a5055d280c96aeb7 (presubmit successful).