Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1755823003: Replace TypeMask.isEmpty by isEmptyOrNull, use isEmpty when it's really empty. (Closed)

Created:
4 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 9 months ago
Reviewers:
asgerf, sra1
CC:
reviews_dartlang.org, asgerf, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace TypeMask.isEmpty by isEmptyOrNull, use isEmpty when it's really empty. R=asgerf@google.com, sra@google.com Committed: https://github.com/dart-lang/sdk/commit/cf78d296d768532da1bc15ba8e0e7af4383e9f1d

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -59 lines) Patch
M pkg/compiler/lib/src/cps_ir/inline.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +6 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/container_type_mask.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/dictionary_type_mask.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 12 chunks +18 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/value_type_mask.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Siggi Cherem (dart-lang)
minor change, but it's was always confusing that isEmpty was not really empty.
4 years, 9 months ago (2016-03-02 20:42:57 UTC) #4
asgerf
Thank you! This has been bothering me for so long. And LGTM.
4 years, 9 months ago (2016-03-03 06:40:49 UTC) #6
sra1
lgtm
4 years, 9 months ago (2016-03-03 07:45:46 UTC) #7
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-03 23:04:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
cf78d296d768532da1bc15ba8e0e7af4383e9f1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698