Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

Issue 1755823003: Replace TypeMask.isEmpty by isEmptyOrNull, use isEmpty when it's really empty. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
diff --git a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
index cbc662cef2cbfdc2b3b61b27c532bbd16d7660be..98a9309d35567c9fd3ce8f42a27751f82b804289 100644
--- a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
+++ b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
@@ -832,7 +832,6 @@ class DynamicCallSiteTypeInformation extends CallSiteTypeInformation {
TypeGraphInferrerEngine inferrer) {
ClassWorld classWorld = inferrer.classWorld;
if (!classWorld.backend.intImplementation.isResolved) return null;
- TypeMask emptyType = const TypeMask.nonNullEmpty();
if (mask == null) return null;
if (!mask.containsOnlyInt(classWorld)) {
return null;
@@ -843,7 +842,7 @@ class DynamicCallSiteTypeInformation extends CallSiteTypeInformation {
ClassElement uint31Implementation = classWorld.backend.uint31Implementation;
bool isInt(info) => info.type.containsOnlyInt(classWorld);
- bool isEmpty(info) => info.type == emptyType;
+ bool isEmpty(info) => info.type.isEmpty;
bool isUInt31(info) {
return info.type.satisfies(uint31Implementation, classWorld);
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698