Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1755683004: Skip attempting to bind a DevicePtr for a removed device. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip attempting to bind a DevicePtr for a removed device. This patch skips calling DeviceManager::GetDevice for a removed device as this is guaranteed to fail. Instead a null DevicePtr is simply passed to WebUSBDeviceImpl which has been updated to handle this. BUG=492204 Committed: https://crrev.com/0c1f5522feb3c65ac1543621e22c75513e3a6f5d Cr-Commit-Position: refs/heads/master@{#378856}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M content/renderer/usb/web_usb_client_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/usb/usb.html View 1 chunk +16 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Reilly Grant (use Gerrit)
Tests! Holy crap!
4 years, 9 months ago (2016-03-02 01:28:29 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-03-02 01:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755683004/20001
4 years, 9 months ago (2016-03-02 21:01:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-02 22:15:06 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 22:16:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c1f5522feb3c65ac1543621e22c75513e3a6f5d
Cr-Commit-Position: refs/heads/master@{#378856}

Powered by Google App Engine
This is Rietveld 408576698