Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1754543003: Add WebUSB layout tests for device disconnection. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebUSB layout tests for device disconnection. These tests ensure that when a device has been disconnected and thus the Mojo pipe between the renderer and browser process is closed calls to methods on the USBDevice object fail correctly by rejecting with a NotFoundError. At the moment this requires WebUSBDeviceImpl to explicitly monitor for connection errors and reset its interface pointer. Ideally this should happen automatically. BUG=492204 Committed: https://crrev.com/0a2ccc59a9951d04d92d721c399f9ceef6e64b11 Cr-Commit-Position: refs/heads/master@{#378816}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addresses rockot@'s nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -30 lines) Patch
M content/renderer/usb/web_usb_device_impl.cc View 7 chunks +49 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/usb/usb.html View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/usb/usbDevice.html View 1 12 chunks +240 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 9 months ago (2016-03-01 22:55:34 UTC) #3
Ken Rockot(use gerrit already)
lgtm with an optional nit and a comment that imho requires action https://codereview.chromium.org/1754543003/diff/1/content/renderer/usb/web_usb_device_impl.cc File content/renderer/usb/web_usb_device_impl.cc ...
4 years, 9 months ago (2016-03-02 01:54:19 UTC) #4
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1754543003/diff/1/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js File third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js (right): https://codereview.chromium.org/1754543003/diff/1/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js#newcode378 third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js:378: mojo.core.close(pipe); On 2016/03/02 01:54:19, Ken Rockot wrote: > nit: ...
4 years, 9 months ago (2016-03-02 19:13:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754543003/20001
4 years, 9 months ago (2016-03-02 19:14:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 20:27:26 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 20:28:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a2ccc59a9951d04d92d721c399f9ceef6e64b11
Cr-Commit-Position: refs/heads/master@{#378816}

Powered by Google App Engine
This is Rietveld 408576698