Issue 1755613003: [Offline pages] Making sure http:// scheme is stripped from OIB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1755613003: [Offline pages] Making sure http:// scheme is stripped from OIB (Closed)

Created:
4 years, 9 months ago by fgorski

Modified:
4 years, 9 months ago

Reviewers:
Ted C

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Offline pages] Making sure http:// scheme is stripped from OIB BUG=591104 R=tedchoc@chromium.org Review URL: https://codereview.chromium.org/1749233003 Cr-Commit-Position: refs/heads/master@{#378563} (cherry picked from commit 1ffb363a1e011a850a4fbaa1f06a2cd318955a9b) Committed: https://chromium.googlesource.com/chromium/src/+/eb6b378606f6b78b6a8a0654bb4295fba5ccd858

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -8 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

fgorski

4 years, 9 months ago (2016-03-01 22:00:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eb6b378606f6b78b6a8a0654bb4295fba5ccd858.