[Offline pages] Making sure http:// scheme is stripped from OIB

[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104
Committed: https://crrev.com/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b
Cr-Commit-Position: refs/heads/master@{#378563}

[fgorski, 2016-03-01 18:04:29]

Description was changed from

==========
[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104
==========

to

==========
[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104
==========

[fgorski, 2016-03-01 18:04:29]

fgorski@chromium.org changed reviewers:
+ tedchoc@chromium.org

[fgorski, 2016-03-01 18:40:54]

Please take a look. I missed the http:// case for the OIB. to improve the code
overall I extracted the path stripping to OfflinePageUtils.

[Ted C, 2016-03-01 18:42:36]

lgtm

https://codereview.chromium.org/1749233003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
(right):

https://codereview.chromium.org/1749233003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java:145:
if (onlineUrl.startsWith("http://")) return onlineUrl.substring(7);
make this an else if to be "slightly" faster

[fgorski, 2016-03-01 19:43:08]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-03-01 19:43:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1749233003/#ps20001
(title: "Addressing CR feedback")

[commit-bot: I haz the power, 2016-03-01 19:43:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749233003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749233003/20001

[commit-bot: I haz the power, 2016-03-01 21:35:05]

Description was changed from

==========
[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104
==========

to

==========
[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104
==========

[commit-bot: I haz the power, 2016-03-01 21:35:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 21:36:15]

Description was changed from

==========
[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104
==========

to

==========
[Offline pages] Making sure http:// scheme is stripped from OIB

BUG=591104

Committed: https://crrev.com/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b
Cr-Commit-Position: refs/heads/master@{#378563}
==========

[commit-bot: I haz the power, 2016-03-01 21:36:16]

Patchset 2 (id:??) landed as
https://crrev.com/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b
Cr-Commit-Position: refs/heads/master@{#378563}